perf(applyNaive): avoid walking the tree for each file in the same directory #11337
Conversation
|
Hi @azr. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
azr
force-pushed
the
tar-rootpath-cache
branch
2 times, most recently
from
d64685a to
dbb7668
Compare
azr
changed the title
azr
force-pushed
the
tar-rootpath-cache
branch
3 times, most recently
from
a23e6f4 to
2303376
Compare
|
@samuelkarp Can you take a look just in case since fs.RootPath() is protecting containerd from malicious images. That being said, I think this change is safe. cachedRootPath.Get returns what fs.RootPath returns. |
|
Hello there ! Coming in this PR to see if there is anything I can do to make merging easier. Cheers ! |
azr
force-pushed
the
tar-rootpath-cache
branch
2 times, most recently
from
e7dbd8b to
31eccab
Compare
azr
force-pushed
the
tar-rootpath-cache
branch
from
31eccab to
ba7750d
Compare
…rectory This for example allowed us to gain ~5s while pulling ghcr.io/huggingface/text-generation-inference:3.0.2 Signed-off-by: Adrien Delorme <[email protected]> Co-Authored-By: Corentin REGAL <[email protected]>
azr
force-pushed
the
tar-rootpath-cache
branch
from
ba7750d to
d8063c3
Compare
|
Hello ! Sorry to ping here ! Is there something missing or that I could to better this one up? Cheers ! |
This for example allowed us to gain ~5s while pulling/unpacking ghcr.io/huggingface/text-generation-inference:3.0.2
Has impact in directories with a lot of files.