[release/1.6] make sure console master tty is closed on task exit #11322
Conversation
Signed-off-by: Henry Wang <[email protected]>
Signed-off-by: Henry Wang <[email protected]>
|
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| "github.com/stretchr/testify/require" | ||
| "k8s.io/client-go/rest" | ||
| remoteclient "k8s.io/client-go/tools/remotecommand" | ||
| criruntime "k8s.io/cri-api/pkg/apis/runtime/v1" |
There was a problem hiding this comment.
We are using an older version of cri-api in 1.6 branch. Ref: https://github.com/containerd/containerd/blob/release/1.6/go.mod#L77.
There was a problem hiding this comment.
We are using an older version of cri-api in 1.6 branch. Ref: https://github.com/containerd/containerd/blob/release/1.6/go.mod#L77.
I'll look into this next week.
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #11161
/assign fuweid