Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] Add support for syncfs after unpack #11267

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[release/1.7] Add support for syncfs after unpack #11267

merged 1 commit into from
Feb 21, 2025

Conversation

tboevil
Copy link
Contributor

@tboevil tboevil commented Jan 16, 2025 •
edited
Loading

@k8s-ci-robot
Copy link

Hi @tboevil. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tboevil tboevil changed the title [release/1.7 backport] [release/1.7 backport] syncfs related feature Jan 16, 2025
@tboevil
Copy link
Contributor Author

tboevil commented Jan 16, 2025

@fuweid PTAL

fuweid
fuweid requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please file two seperate backport pull requests. thanks

@tboevil tboevil changed the title [release/1.7 backport] syncfs related feature [release/1.7 backport] pick #10284 Jan 23, 2025
@tboevil tboevil requested a review from fuweid January 23, 2025 03:09
@tboevil
Copy link
Contributor Author

tboevil commented Jan 23, 2025 •
edited
Loading

please file two seperate backport pull requests. thanks

Done. Another PR is here： #11305

@fuweid fuweid changed the title [release/1.7 backport] pick #10284 [release/1.7] Support to syncfs after pull by using diff plugin Jan 23, 2025
@fuweid
Copy link
Member

fuweid commented Jan 23, 2025

Hi @tboevil please use cherry-pick -sx thanks

@ningmingxiao @tboevil
support to syncfs after pull by using diff plugin
8bc21cb 
Signed-off-by: ningmingxiao <[email protected]>
(cherry picked from commit 0e4f210)
Signed-off-by: Qiyuan Liang <[email protected]>
fuweid
fuweid approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's feature but it can mitigate page-cache loss issue. I vote it to get merged.

@fuweid fuweid merged commit 9dbb9ed into containerd:release/1.7 Feb 21, 2025
57 checks passed
@dmcgowan dmcgowan changed the title [release/1.7] Support to syncfs after pull by using diff plugin [release/1.7] Add support for syncfs after unpack during pull Feb 25, 2025
@dmcgowan dmcgowan changed the title [release/1.7] Add support for syncfs after unpack during pull [release/1.7] Add support for syncfs after unpack Feb 25, 2025
@dmcgowan dmcgowan mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
impact/changelog ok-to-test size/S
Projects
Pull Request Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tboevil @k8s-ci-robot @fuweid @cpuguy83 @dmcgowan @ningmingxiao