Move CDI device spec out of the OCI package#11262
Merged
AkihiroSuda merged 2 commits intocontainerd:mainfrom Jan 14, 2025
Merged
Move CDI device spec out of the OCI package#11262AkihiroSuda merged 2 commits intocontainerd:mainfrom
AkihiroSuda merged 2 commits intocontainerd:mainfrom
Conversation
The CDI device injection spec opt was mistakenly added to the OCI package which brought in an unintended dependency on CDI and its transitive dependencies. Signed-off-by: Derek McGowan <[email protected]>
This function has been moved to prevent an unintended dependency on CDI. Signed-off-by: Derek McGowan <[email protected]>
samuelkarp
approved these changes
Jan 14, 2025
AkihiroSuda
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDI device injection spec opt was mistakenly added to the OCI
package which brought in an unintended dependency on CDI and its
transitive dependencies.
Not going to move it to an internal package since it may still be useful for clients. Its early enough in 2.0 to clean this up before it clients start utilizing and making it more difficult to move without breaking someone. This was quickly caught in buildkit which uses the spec opts but does not need/want those transitive dependencies pulled in.