Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update runc binary to v1.2.4 #11230

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented Jan 8, 2025

This is the fourth patch release of the 1.2.z release branch of runc. It includes a fix for a regression introduced in 1.2.0 related to the default device list.

  • Re-add tun/tap devices to built-in allowed devices lists.

    In runc 1.2.0 we removed these devices from the default allow-list (which were added seemingly by accident early in Docker's history) as a precaution in order to try to reduce the attack surface of device inodes available to most containers At the time we thought that the vast majority of users using tun/tap would already be specifying what devices they need (such as by using --device with Docker/Podman) as opposed to doing the mknod manually, and thus there would've been no user-visible change.

    Unfortunately, it seems that this regressed a noticeable number of
    users (and not all higher-level tools provide easy ways to specify devices to allow) and so this change needed to be reverted. Users that do not need these devices are recommended to explicitly disable them by adding deny rules in their container configuration.

diff: opencontainers/runc@v1.2.3...v1.2.4

This is the fourth patch release of the 1.2.z release branch of runc. It
includes a fix for a regression introduced in 1.2.0 related to the
default device list.

- Re-add tun/tap devices to built-in allowed devices lists.

  In runc 1.2.0 we removed these devices from the default allow-list
(which were added seemingly by accident early in Docker's history) as
a precaution in order to try to reduce the attack surface of device
inodes available to most containers. At the time we thought
that the vast majority of users using tun/tap would already be
specifying what devices they need (such as by using --device with
Docker/Podman) as opposed to doing the mknod manually, and thus
there would've been no user-visible change.

  Unfortunately, it seems that this regressed a noticeable number of
users (and not all higher-level tools provide easy ways to specify
devices to allow) and so this change needed to be reverted. Users
that do not need these devices are recommended to explicitly disable
them by adding deny rules in their container configuration.

diff: opencontainers/runc@v1.2.3...v1.2.4

Signed-off-by: Akhil Mohan <[email protected]>
@thaJeztah thaJeztah added cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Jan 8, 2025
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@mxpv mxpv added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@mxpv mxpv added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@dmcgowan dmcgowan added this pull request to the merge queue Jan 8, 2025
Merged via the queue into containerd:main with commit 51809b1 Jan 9, 2025
58 checks passed
@akhilerm akhilerm deleted the update-runc-1.2.4 branch January 9, 2025 02:40
@akhilerm
Copy link
Member Author

akhilerm commented Jan 9, 2025

/cherry-pick release/2.0
/cherry-pick release/1.7
/cherry-pick release/1.6

@k8s-infra-cherrypick-robot

@akhilerm: new pull request created: #11237

In response to this:

/cherry-pick release/2.0
/cherry-pick release/1.7
/cherry-pick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@akhilerm: new pull request created: #11238

In response to this:

/cherry-pick release/2.0
/cherry-pick release/1.7
/cherry-pick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@akhilerm: new pull request created: #11239

In response to this:

/cherry-pick release/2.0
/cherry-pick release/1.7
/cherry-pick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants