Skip to content

Makefile: fix INTEGRATION_PACKAGE#1118

Merged
stevvooe merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-integration
Jun 29, 2017
Merged

Makefile: fix INTEGRATION_PACKAGE#1118
stevvooe merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-integration

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Signed-off-by: Akihiro Suda [email protected]

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   54.51%   54.51%           
=======================================
  Files          16       16           
  Lines        1229     1229           
=======================================
  Hits          670      670           
  Misses        386      386           
  Partials      173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55861c1...2c29342. Read the comment docs.

@AkihiroSuda
Copy link
Copy Markdown
Member Author

If #1117 gets merged before this, we would need to put -test.root to the integration target and coverage-integration target.

So PTAL #1117 first.

@AkihiroSuda
Copy link
Copy Markdown
Member Author

Or it might be good to just remove integration target.

@stevvooe
Copy link
Copy Markdown
Member

LGTM

We'll follow up the other problems in a separate PR.

@stevvooe stevvooe merged commit fb7f43f into containerd:master Jun 29, 2017
ianlewis pushed a commit to ianlewis/containerd that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants