*_test.go: fix test conditions#1117
Merged
estesp merged 1 commit intocontainerd:masterfrom Jun 30, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
===========================================
- Coverage 54.51% 34.71% -19.81%
===========================================
Files 16 28 +12
Lines 1229 2322 +1093
===========================================
+ Hits 670 806 +136
- Misses 386 1341 +955
- Partials 173 175 +2
Continue to review full report at Codecov.
|
Member
There was a problem hiding this comment.
Why are you taking stderr and the os.Exit functions to this? Wouldn't it always be the same for testing?
- add `testutil.RequiresRoot()` to TestMain
- moved `if testing.Short{ t.Skip() }` from each of the tests into a
common `newClient()`
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
fix-root-test
branch
from
115bb85 to
eeb74d4
Compare
Member
Author
|
@crosbymichael ok, updated PR |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testutil.RequiresRoot()to TestMainif testing.Short{ t.Skip() }from each of the tests into acommon
newClient()Signed-off-by: Akihiro Suda [email protected]