.gitignore vendor\pkg#111
Conversation
Signed-off-by: John Howard <[email protected]>
|
To be compatible with the vendoring scheme in Go1.6, the vendor/src directory will actually have to be removed. The |
|
@stevvooe Sure, in time, but currently the dockerfile is using go 1.5.2, and I keep getting the vendor/pkg directory included in my repo git changes slowing me down trying to get this to compile on Windows. |
|
@stevvooe, moved the discussion to https://github.com/docker/containerd/issues/113. Go 1.6 is not required as long as the GO15VENDOREXPERIMENT flag is set, but I guess the switch is going to happen in the future. |
|
So where does that leave this PR in the meantime? It's stuck in limbo land while not on 1.6 and the new vendoring scheme.... |
|
@jhowardmsft LGTM. No problem waiting for vendoring for this. Another option is to add this to your global git config. |
|
This should be resolved now that we updated the vendor layout. |
Add ToResources func for spec to v2.Resources
bump to containerd 1.2.10-2
5 participants
Signed-off-by: John Howard [email protected]
Same as for github.com/docker/docker