Hi @xbt573. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

https://github.com/torvalds/linux/blame/master/include/uapi/linux/fs.h#L223-L224

Oh, didn't see this one. Then int32 assumption is very incorrect, but as we see int64 or long doesn't work with big endian machines.
Is there other ways to work around this issue for big endian machines?

https://github.com/torvalds/linux/blame/master/include/uapi/linux/fs.h#L223-L224

Oh, didn't see this one. Then int32 assumption is very incorrect, but as we see int64 or long doesn't work with big endian machines. Is there other ways to work around this issue for big endian machines?

we can build and check goos on a per platform basis

I checked all possible output flags for FS_IOC_GETFLAGS and their total bitwise OR value is 4076863487, which is less than uint32 maximum limit. Also, getting all extended attributes enabled is probably impossible, all i managed to get is 252 without verity and 1048576 with it.

--S-iadAc------------- 252
--------------------V- 1048576

Also, i asked about this on Golang issue tracker and got this response: golang/go#70302 (comment)

If this is OK we can change attr variable to uint32 and merge it. I tested it briefly on s390x and it worked as expected:

[xbt573@localhost xd]$ lsattr test
--------------------V- test
[xbt573@localhost xd]$ ./xd test
1048576

#define FS_VERITY_FL			0x00100000 /* Verity protected inode */
// 0x00100000 == 1048576

I checked all possible output flags for FS_IOC_GETFLAGS and their total bitwise OR value is 4076863487, which is less than uint32 maximum limit. Also, getting all extended attributes enabled is probably impossible, all i managed to get is 252 without verity and 1048576 with it.

--S-iadAc------------- 252
--------------------V- 1048576

Also, i asked about this on Golang issue tracker and got this response: golang/go#70302 (comment)

If this is OK we can change attr variable to uint32 and merge it. I tested it briefly on s390x and it worked as expected:

[xbt573@localhost xd]$ lsattr test
--------------------V- test
[xbt573@localhost xd]$ ./xd test
1048576

#define FS_VERITY_FL			0x00100000 /* Verity protected inode */
// 0x00100000 == 1048576

thx was that s390x system 32 or 64bit.. presume the later and can move along but would be nice to know if we have an endian issue with go int to c long on 32bit and or 64bit..

Isn't c long int64 on 64 bit systems.. Should this be platform dependent?

https://github.com/torvalds/linux/blame/master/include/uapi/linux/fs.h#L223-L224

See the note in the man page: https://man7.org/linux/man-pages/man2/ioctl_iflags.2.html#NOTES

/cherrypick release/2.0

@estesp: new pull request created: #11005