Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Pod assigned IPs to NRI plugins #10921

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Expose Pod assigned IPs to NRI plugins #10921

merged 2 commits into from
Nov 7, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Nov 1, 2024

Follow up on containerd/nri#119

Expose the assigned IPs to the Pod sandbox to the NRI plugins

@k8s-ci-robot
Copy link

Hi @aojea. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the area/nri Node Resource Interface (NRI) label Nov 1, 2024
@aojea
Copy link
Contributor Author

aojea commented Nov 1, 2024

/hold

We may want to wait for a tagged release of NRI, opening to get signal on CI

/assign @samuelkarp

@samuelkarp
Copy link
Member

We may want to wait for a tagged release of NRI

Yes, we should tag a new release of NRI

@samuelkarp
Copy link
Member

It looks like your commits are missing the Signed-off-by line.

@aojea aojea mentioned this pull request Nov 1, 2024
Merged
@samuelkarp
Copy link
Member

/ok-to-test

@samuelkarp
Copy link
Member

@aojea https://github.com/containerd/nri/releases/tag/v0.8.0

aojea added 2 commits November 1, 2024 19:52
@aojea
bump nri version to get PodIPs
a256f32 
revendor the nri version that allows to expose the pod IPs to the NRI
plugins

Signed-off-by: Antonio Ojea <[email protected]>
@aojea
nri: report pod ips to the nri plugins
bc056a5 
Signed-off-by: Antonio Ojea <[email protected]>
@aojea
Copy link
Contributor Author

aojea commented Nov 1, 2024

@aojea https://github.com/containerd/nri/releases/tag/v0.8.0

updated with the new version, thanks

@mxpv mxpv added this pull request to the merge queue Nov 7, 2024
Merged via the queue into containerd:main with commit 1d6fdda Nov 7, 2024
59 checks passed
@dmcgowan dmcgowan changed the title expose Pod assigned IPs to NRI plugins Expose Pod assigned IPs to NRI plugins Mar 8, 2025
@dmcgowan dmcgowan mentioned this pull request Mar 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@mxpv mxpv mxpv approved these changes

Assignees

@samuelkarp samuelkarp

Labels
area/nri Node Resource Interface (NRI) impact/changelog ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aojea @k8s-ci-robot @samuelkarp @mxpv