services/snapshots: include name of snapshotter in debug logs #10919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thaJeztah
commented
Oct 31, 2024
thaJeztah
commented
- combine consecutive "WithField" calls to "WithFields", as multiple calls is known to be expensive.
- include a "snapshotter" field in logs to allow correlating actions with specific snapshotters.
AkihiroSuda
approved these changes
Oct 31, 2024
dmcgowan
previously approved these changes
Oct 31, 2024
dmcgowan
reviewed
Oct 31, 2024
| @@ -135,7 +135,7 @@ func (s *service) Mounts(ctx context.Context, mr *snapshotsapi.MountsRequest) (* | |||
| } | |||
|
|
|||
| func (s *service) Commit(ctx context.Context, cr *snapshotsapi.CommitSnapshotRequest) (*ptypes.Empty, error) { | |||
| log.G(ctx).WithField("key", cr.Key).WithField("name", cr.Name).Debugf("commit snapshot") | |||
| log.G(ctx).WithFields(log.Fields{"key": cr.Key, "snapshotter": cr.Snapshotter}).Debugf("commit snapshot") | |||
There was a problem hiding this comment.
doh, good catch; sorry for that 🙈 updated 👍
- combine consecutive "WithField" calls to "WithFields", as multiple calls is known to be expensive. - include a "snapshotter" field in logs to allow correlating actions with specific snapshotters. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
snapshot_logs_structured
branch
from
4f301a2 to
4594f5c
Compare
estesp
approved these changes
Nov 1, 2024
samuelkarp
added
cherry-pick/1.6.x
This was referenced Nov 2, 2024
austinvazquez
added
cherry-picked/1.6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.