Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.6 backport] update to go1.23.2,go1.22.8 #10809

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[release/1.6 backport] update to go1.23.2,go1.22.8 #10809

merged 1 commit into from
Oct 10, 2024

Conversation

austinvazquez
Copy link
Member

(cherry picked from commit 46f5a0d)

@austinvazquez
update to go1.23.2,go1.22.8
1ca261f 
Signed-off-by: Austin Vazquez <[email protected]>
(cherry picked from commit 46f5a0d)
Signed-off-by: Austin Vazquez <[email protected]>
@k8s-ci-robot
Copy link

Hi @austinvazquez. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez marked this pull request as ready for review October 9, 2024 22:17
@dosubot dosubot bot added area/toolchain Build and Release Toolchain github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code labels Oct 9, 2024
@samuelkarp
Copy link
Member

/ok-to-test

@akhilerm
Copy link
Member

Should we also update the go version in the go.mod https://github.com/containerd/containerd/blob/release/1.6/go.mod#L3. Its at 1.19 now

@estesp
Copy link
Member

estesp commented Oct 10, 2024

Should we also update the go version in the go.mod https://github.com/containerd/containerd/blob/release/1.6/go.mod#L3. Its at 1.19 now

Sounds like a reasonable idea; let's do it in a follow-up since this is a backport

@estesp estesp merged commit a76e482 into containerd:release/1.6 Oct 10, 2024
48 checks passed
@austinvazquez austinvazquez deleted the cherry-pick-46f5a0d9392f13f5f1402f314e6246e692e64428-to-1.6 branch October 10, 2024 14:29
@lujinda lujinda mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@akhilerm akhilerm akhilerm approved these changes

Assignees
No one assigned
Labels
area/toolchain Build and Release Toolchain github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@austinvazquez @k8s-ci-robot @samuelkarp @akhilerm @estesp @dmcgowan