Skip to content

[release/1.7] prow: allow ENABLE_CRI_SANDBOXES to be configured#10801

Merged
samuelkarp merged 1 commit intocontainerd:release/1.7from
samuelkarp:prow-containerd-node-e2e-1-7-sandboxed
Oct 10, 2024
Merged

[release/1.7] prow: allow ENABLE_CRI_SANDBOXES to be configured#10801
samuelkarp merged 1 commit intocontainerd:release/1.7from
samuelkarp:prow-containerd-node-e2e-1-7-sandboxed

Conversation

@samuelkarp
Copy link
Copy Markdown
Member

The pull-containerd-node-e2e-1-7-sandboxed job will set ENABLE_CRI_SANDBOXES for containerd 1.7 and enable us to validate that the sbserver backend works with e2e tests.

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

samuelkarp added a commit to samuelkarp/kubernetes-test-infra that referenced this pull request Oct 8, 2024
This change will enable the pull-containerd-node-e2e-1-7-sandboxed job
to pass down configuration enabling CRI sandboxes in containerd 1.7.
This is an optional CRI backend in 1.7 and will be the new backend in
containerd 2.0.

Corresponding containerd change: containerd/containerd#10801

Signed-off-by: Samuel Karp <[email protected]>
@samuelkarp
Copy link
Copy Markdown
Member Author

This will be testable once kubernetes/test-infra#33603 is merged.

@samuelkarp
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e-1-7-sandboxed

@samuelkarp samuelkarp force-pushed the prow-containerd-node-e2e-1-7-sandboxed branch from 3bff4b5 to e137924 Compare October 8, 2024 22:22
@samuelkarp
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e-1-7-sandboxed

The pull-containerd-node-e2e-1-7-sandboxed job will set
ENABLE_CRI_SANDBOXES for containerd 1.7 and enable us to validate that
the sbserver backend works with e2e tests.

Signed-off-by: Samuel Karp <[email protected]>
@samuelkarp samuelkarp force-pushed the prow-containerd-node-e2e-1-7-sandboxed branch from e137924 to 633201a Compare October 8, 2024 23:07
@samuelkarp
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e-1-7-sandboxed

@samuelkarp
Copy link
Copy Markdown
Member Author

Looks like I missed a bit in the first test-infra PR; kubernetes/test-infra#33606 should fix it.

@samuelkarp
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e-1-7-sandboxed

@akhilerm
Copy link
Copy Markdown
Member

akhilerm commented Oct 9, 2024

The pull-containerd-node-e2e-1-7-sandboxed job will set ENABLE_CRI_SANDBOXES for containerd 1.7 and enable us to validate that the sbserver backend works with e2e tests.

So, the sandboxed jobs for 1.7 were testing without sbserver till now.

@samuelkarp
Copy link
Copy Markdown
Member Author

So, the sandboxed jobs for 1.7 were testing without sbserver till now.

Yeah, the pull-containerd-node-e2e-1-7-sandboxed prow job wasn't working properly. Our GitHub actions workflows for containerd CI are working, though, so we have had testing there.

@samuelkarp samuelkarp force-pushed the prow-containerd-node-e2e-1-7-sandboxed branch from 633201a to ae11176 Compare October 9, 2024 20:12
@samuelkarp
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e-1-7-sandboxed

@samuelkarp samuelkarp marked this pull request as ready for review October 9, 2024 21:28
@dosubot dosubot Bot added the area/cri Container Runtime Interface (CRI) label Oct 9, 2024
@samuelkarp samuelkarp changed the title prow: allow ENABLE_CRI_SANDBOXES to be configured [release/1.7] prow: allow ENABLE_CRI_SANDBOXES to be configured Oct 9, 2024
@samuelkarp
Copy link
Copy Markdown
Member Author

/retest

@samuelkarp samuelkarp merged commit 7428c1e into containerd:release/1.7 Oct 10, 2024
hbostan pushed a commit to hbostan/test-infra that referenced this pull request Feb 5, 2025
This change will enable the pull-containerd-node-e2e-1-7-sandboxed job
to pass down configuration enabling CRI sandboxes in containerd 1.7.
This is an optional CRI backend in 1.7 and will be the new backend in
containerd 2.0.

Corresponding containerd change: containerd/containerd#10801

Signed-off-by: Samuel Karp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants