[release/1.7] Add errdefs aliases#10792
Merged
estesp merged 1 commit intocontainerd:release/1.7from Oct 8, 2024
Merged
Conversation
Update to errdefs 0.3.0 which only includes the main error definitions Signed-off-by: Derek McGowan <[email protected]>
dosubot
bot
added
dependencies
samuelkarp
approved these changes
Oct 8, 2024
dims
approved these changes
Oct 8, 2024
austinvazquez
approved these changes
Oct 8, 2024
zouyee
approved these changes
Oct 8, 2024
estesp
approved these changes
Oct 8, 2024
dims
approved these changes
Oct 8, 2024
This was referenced Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to errdefs 0.3.0 which only includes the main error definitions. This preserves the revert of the grpc functions and allows type matching between errdefs error types and containerd 1.7 error types. The grpc related functionality is completely removed from the errdefs 0.3.0 module, importers can either use the definition in the containerd 1.7 errdefs package like before or can import the separate errdefs/pkg module. We will not use that module in containerd 1.7, although they produce the same types now.