[release/1.7 backport] TestNewBinaryIOCleanup: fix a comment, minor rewrite#10776
Merged
dmcgowan merged 1 commit intocontainerd:release/1.7from Oct 8, 2024
Conversation
The main reason is to improve the comment about pidfd in Go 1.23+. While at it: - avoid slice manipulation as we only need count; - avoid repeating "/proc/self/fd". Updates: containerd#10345. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 94c1632) Signed-off-by: Austin Vazquez <[email protected]>
|
Hi @austinvazquez. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dmcgowan
approved these changes
Oct 8, 2024
estesp
approved these changes
Oct 8, 2024
austinvazquez
deleted the
cherry-pick-94c163209db612dbf1394e73060031953b34ac88-to-1.7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason is to improve the comment about pidfd in Go 1.23+.
While at it:
Updates: #10345.
(cherry picked from commit 94c1632)