Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to go1.23.2,go1.22.8 #10772

Merged
merged 1 commit into from
Oct 8, 2024
Merged

update to go1.23.2,go1.22.8 #10772

merged 1 commit into from
Oct 8, 2024

Conversation

austinvazquez
Copy link
Member

Update tooling to Go 1.23.2 and 1.22.8

go1.23.2 (released 2024-10-01) includes fixes to the compiler, cgo, the runtime, and the maps, os, os/exec, time, and unique packages. See the Go 1.23.2 milestone on our issue tracker for details.

go1.22.8 (released 2024-10-01) includes fixes to cgo, and the maps and syscall packages. See the Go 1.22.8 milestone on our issue tracker for details.

@k8s-ci-robot
Copy link

Hi @austinvazquez. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez
Copy link
Member Author

Go 1.23.2 backports golang/go#69119. Is there expectation to continue to carry https://github.com/containerd/containerd/blame/59ffbf4ce32c71c73627bf0cb3b94587677a0020/pkg/sys/unshare_linux.go#L73-L86?

@estesp
Copy link
Member

estesp commented Oct 4, 2024

Go 1.23.2 backports golang/go#69119. Is there expectation to continue to carry https://github.com/containerd/containerd/blame/59ffbf4ce32c71c73627bf0cb3b94587677a0020/pkg/sys/unshare_linux.go#L73-L86?

We can't control the version of Go that distros or other downstream consumers use, so I think we have to leave this here as those 2 versions (1.23.0 and 1.23.1) will continue to have the issue even though newer versions are fixed.

@austinvazquez austinvazquez marked this pull request as ready for review October 4, 2024 21:05
@dosubot dosubot bot added area/toolchain Build and Release Toolchain github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code labels Oct 4, 2024
@austinvazquez
update to go1.23.2,go1.22.8
46f5a0d 
Signed-off-by: Austin Vazquez <[email protected]>
@fuweid fuweid added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@estesp estesp added this pull request to the merge queue Oct 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 8, 2024
@estesp
Merge pull request #10772 from austinvazquez/update-golang-1.23.2
867ca7e 
update to go1.23.2,go1.22.8
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@estesp estesp added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Oct 8, 2024
Merged via the queue into containerd:main with commit 179b8d9 Oct 8, 2024
60 checks passed
@austinvazquez austinvazquez deleted the update-golang-1.23.2 branch October 8, 2024 14:08
This was referenced Oct 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
area/toolchain Build and Release Toolchain github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code needs-ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@austinvazquez @k8s-ci-robot @estesp @fuweid @AkihiroSuda