Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.6] Add check for CNI plugins before tearing down pod network #10766

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[release/1.6] Add check for CNI plugins before tearing down pod network #10766

merged 1 commit into from
Oct 4, 2024

Conversation

sameersaeed
Copy link
Contributor

@sameersaeed sameersaeed commented Oct 3, 2024 •
edited
Loading

Cherry pick of #10744 for release 1.6.36

@k8s-ci-robot
Copy link

Hi @sameersaeed. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the area/cri Container Runtime Interface (CRI) label Oct 3, 2024
@sameersaeed sameersaeed force-pushed the v1.6.36-sandbox-cni-plugins branch from 26f0a7a to 5dc4223 Compare October 3, 2024 18:07
@sameersaeed sameersaeed force-pushed the v1.6.36-sandbox-cni-plugins branch from 5dc4223 to 49a86e4 Compare October 3, 2024 18:21
@sameersaeed sameersaeed force-pushed the v1.6.36-sandbox-cni-plugins branch from 49a86e4 to ca6516e Compare October 3, 2024 18:58
@mikebrow
Copy link
Member

mikebrow commented Oct 3, 2024

/ok-to-test

@mikebrow
Copy link
Member

mikebrow commented Oct 3, 2024

noting the package moved from pkg/ to internal/ probably would not have been auto cherry pickable.

mikebrow
mikebrow approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit da9421e into containerd:release/1.6 Oct 4, 2024
48 checks passed
@lujinda lujinda mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
area/cri Container Runtime Interface (CRI) impact/changelog ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sameersaeed @k8s-ci-robot @mikebrow @mxpv @dmcgowan