[release/1.6] integration: regression test for issue 10589#10683
Merged
samuelkarp merged 2 commits intocontainerd:release/1.6from Sep 6, 2024
Merged
[release/1.6] integration: regression test for issue 10589#10683samuelkarp merged 2 commits intocontainerd:release/1.6from
samuelkarp merged 2 commits intocontainerd:release/1.6from
Conversation
Signed-off-by: Samuel Karp <[email protected]> (cherry picked from commit 5f37a2c) Signed-off-by: Samuel Karp <[email protected]>
This issue was caused by a race between init exits and new exec process tracking inside the shim. The test operates by controlling the time between when the shim invokes "runc exec" and when the actual "runc exec" is triggered. This allows validating that races for shim state tracking between pre- and post-start of the exec process do not exist. Relates to containerd#10589 Signed-off-by: Samuel Karp <[email protected]> (cherry picked from commit 18725f0) Signed-off-by: Samuel Karp <[email protected]>
samuelkarp
force-pushed
the
shim-exec-fp-test-1.6
branch
from
23a07d1 to
ab9fedd
Compare
dims
reviewed
Sep 6, 2024
| if f := os.Getenv("RUNC_FLAVOR"); f != "" && f != "runc" { | ||
| t.Skip("test requires runc") | ||
| } | ||
| if rt := os.Getenv("TEST_RUNTIME"); rt != "" && rt != plugin.RuntimeRuncV2 { |
cpuguy83
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #10649
This issue was caused by a race between init exits and new exec process tracking inside the shim. The test operates by controlling the time between when the shim invokes "runc exec" and when the actual "runc exec" is triggered. This allows validating that races for shim state tracking between pre- and post-start of the exec process do not exist.
Relates to #10589
/cc @laurazard