[release/1.7] Cumulative stats can't decrease#10670
Merged
samuelkarp merged 2 commits intocontainerd:release/1.7from Sep 3, 2024
Merged
[release/1.7] Cumulative stats can't decrease#10670samuelkarp merged 2 commits intocontainerd:release/1.7from
samuelkarp merged 2 commits intocontainerd:release/1.7from
Conversation
During removal of the container a stat value might be reported as zero; in this case the caluclation could end up with an extremely large number. If the cumulative stat decreases report zero. Signed-off-by: James Sturtevant <[email protected]> (cherry picked from commit f6677a4) Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Contributor
Author
|
xref #10652 |
samuelkarp
changed the title
samuelkarp
approved these changes
Sep 3, 2024
Contributor
Author
|
/test pull-containerd-node-e2e-1-7 |
Contributor
Author
cpuguy83
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
pkg/cri/sbserver/container_stats_list_test.go
There was a problem hiding this comment.
pkg/cri/sbserver/container_stats_list_test.go
There was a problem hiding this comment.
pkg/cri/server/container_stats_list.go
There was a problem hiding this comment.
pkg/cri/server/container_stats_list_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of f6677a4