Skip to content

TestNewBinaryIOCleanup: fix a comment, minor rewrite#10597

Merged
estesp merged 1 commit intocontainerd:mainfrom
kolyshkin:pidfd
Aug 29, 2024
Merged

TestNewBinaryIOCleanup: fix a comment, minor rewrite#10597
estesp merged 1 commit intocontainerd:mainfrom
kolyshkin:pidfd

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented Aug 15, 2024

The main reason is to improve the comment about pidfd in Go 1.23+.

While at it:

  • avoid slice manipulation as we only need count;
  • avoid repeating "/proc/self/fd".

Updates: #10345.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 15, 2024

Hi @kolyshkin. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

akhilerm
akhilerm reviewed Aug 15, 2024
View reviewed changes
Comment thread cmd/containerd-shim-runc-v2/process/io_test.go Outdated
@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 26, 2024

ping @kolyshkin ; can you re-push with the "fmt" import removed? Linter caught the unused package from your change

@kolyshkin
TestNewBinaryIOCleanup: fix a comment, minor rewrite
94c1632 
The main reason is to improve the comment about pidfd in Go 1.23+.

While at it:
 - avoid slice manipulation as we only need count;
 - avoid repeating "/proc/self/fd".

Updates: containerd#10345.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Aug 28, 2024 •
edited
Loading

ping @kolyshkin ; can you re-push with the "fmt" import removed? Linter caught the unused package from your change

My bad; done.

@estesp estesp added this pull request to the merge queue Aug 29, 2024
Merged via the queue into containerd:main with commit 17a7538 Aug 29, 2024
@thaJeztah thaJeztah added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Aug 29, 2024
@austinvazquez austinvazquez mentioned this pull request Oct 4, 2024
Merged
@austinvazquez austinvazquez added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@akhilerm akhilerm akhilerm approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch needs-ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kolyshkin @k8s-ci-robot @estesp @akhilerm @thaJeztah @austinvazquez