Skip to content

[release/1.6] move builds to go1.22 and testing to go1.23#10595

Merged
AkihiroSuda merged 2 commits intocontainerd:release/1.6from
akhilerm:add-go-1.23-1.6
Sep 3, 2024
Merged

[release/1.6] move builds to go1.22 and testing to go1.23#10595
AkihiroSuda merged 2 commits intocontainerd:release/1.6from
akhilerm:add-go-1.23-1.6

Conversation

@akhilerm
Copy link
Copy Markdown
Member

@akhilerm akhilerm commented Aug 15, 2024

  • add go1.23.0 to testing matrix and move builds and releases to go1.22.6
  • update golangci-lint to 1.60.1

Release binaries will be now built with go1.22.6

@dosubot dosubot Bot added area/github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code labels Aug 15, 2024
@akhilerm akhilerm added the area/toolchain Build and Release Toolchain label Aug 15, 2024
@akhilerm akhilerm marked this pull request as draft August 15, 2024 04:50
Comment thread go.mod Outdated
Comment thread integration/client/go.mod Outdated
@akhilerm akhilerm changed the title [release/1.6] add go1.23.0, drop go1.21.x [release/1.6] move builds to go1.22 and testing to go1.23 Aug 26, 2024
- switch release and build jobs to 1.22.6 from 1.21.13
- add go1.23.0 to CI matrix
- remove go1.21 from CI matrix

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm akhilerm marked this pull request as ready for review September 2, 2024 20:24
cd "$GOPATH"
GO111MODULE=off go get -d github.com/gogo/googleapis || true
GO111MODULE=off go get -d github.com/gogo/protobuf || true
GOGO_DIR="$GOPATH/src/github.com/gogo"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @dmcgowan

This change is done so that we can get the gogo proto sources when using 1.22 as the default go get behaviour has changed.

@AkihiroSuda AkihiroSuda merged commit 9498548 into containerd:release/1.6 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/github_actions Pull requests that update GitHub Actions code area/toolchain Build and Release Toolchain go Pull requests that update Go code size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants