[release/1.6] move builds to go1.22 and testing to go1.23#10595
Merged
AkihiroSuda merged 2 commits intocontainerd:release/1.6from Sep 3, 2024
Merged
[release/1.6] move builds to go1.22 and testing to go1.23#10595AkihiroSuda merged 2 commits intocontainerd:release/1.6from
AkihiroSuda merged 2 commits intocontainerd:release/1.6from
Conversation
56e2bd9 to
6130ae0
Compare
thaJeztah
reviewed
Aug 23, 2024
6130ae0 to
d1d1be0
Compare
- switch release and build jobs to 1.22.6 from 1.21.13 - add go1.23.0 to CI matrix - remove go1.21 from CI matrix Signed-off-by: Akhil Mohan <[email protected]>
d1d1be0 to
bbeb4e9
Compare
bbeb4e9 to
a1290b2
Compare
akhilerm
commented
Sep 2, 2024
| cd "$GOPATH" | ||
| GO111MODULE=off go get -d github.com/gogo/googleapis || true | ||
| GO111MODULE=off go get -d github.com/gogo/protobuf || true | ||
| GOGO_DIR="$GOPATH/src/github.com/gogo" |
Member
Author
There was a problem hiding this comment.
/cc @dmcgowan
This change is done so that we can get the gogo proto sources when using 1.22 as the default go get behaviour has changed.
dmcgowan
approved these changes
Sep 2, 2024
laurazard
approved these changes
Sep 3, 2024
Signed-off-by: Akhil Mohan <[email protected]>
a1290b2 to
0bbc90a
Compare
AkihiroSuda
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release binaries will be now built with go1.22.6