Skip to content

docs: Update BUILDING.md#10593

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
jjmaestro:patch-1
Aug 15, 2024
Merged

docs: Update BUILDING.md#10593
AkihiroSuda merged 1 commit intocontainerd:mainfrom
jjmaestro:patch-1

Conversation

@jjmaestro
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @jjmaestro. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added the kind/docs label Aug 14, 2024
@jjmaestro
Copy link
Copy Markdown
Contributor Author

Good bot :)

Comment thread BUILDING.md Outdated
Comment thread BUILDING.md Outdated
Comment thread BUILDING.md Outdated
Comment thread BUILDING.md
Comment thread .github/workflows/windows-hyperv-periodic.yml
Signed-off-by: Javier Maestro <[email protected]>
@AkihiroSuda AkihiroSuda enabled auto-merge August 15, 2024 17:24
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Aug 15, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 15, 2024
@jjmaestro
Copy link
Copy Markdown
Contributor Author

hmm... so, some checks have failed! I'm surprised since the change is a doc change so... :-? are these caused by flaky tests or something similar? Looking at the failed checks it does look like it could be that, I think?

@AkihiroSuda AkihiroSuda added this pull request to the merge queue Aug 15, 2024
Merged via the queue into containerd:main with commit 919beb1 Aug 15, 2024
@jjmaestro
Copy link
Copy Markdown
Contributor Author

🎉 Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants