Skip to content

[release/1.6] Ensure the CRIAPIV1Alpha2 warning's lastOccurrence is accurate#10582

Merged
samuelkarp merged 1 commit intocontainerd:release/1.6from
chrishenzie:v1alpha2-cri-api-warnings-1.6
Aug 13, 2024
Merged

[release/1.6] Ensure the CRIAPIV1Alpha2 warning's lastOccurrence is accurate#10582
samuelkarp merged 1 commit intocontainerd:release/1.6from
chrishenzie:v1alpha2-cri-api-warnings-1.6

Conversation

@chrishenzie
Copy link
Copy Markdown
Member

This helps gather more accurate API usage data that informs efforts on how to safely migrate containerd clients to 2.0.

This is a chery-pick of #10571.

/cc @samuelkarp @tallclair
/hold

Waiting on 1.7 PR to be merged first.

@k8s-ci-robot
Copy link
Copy Markdown

@chrishenzie: GitHub didn't allow me to request PR reviews from the following users: tallclair.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This helps gather more accurate API usage data that informs efforts on how to safely migrate containerd clients to 2.0.

This is a chery-pick of #10571.

/cc @samuelkarp @tallclair
/hold

Waiting on 1.7 PR to be merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @chrishenzie. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added the area/cri Container Runtime Interface (CRI) label Aug 12, 2024
@samuelkarp
Copy link
Copy Markdown
Member

Can you use git cherry-pick -xs to preserve the original commit hash?

@samuelkarp
Copy link
Copy Markdown
Member

/ok-to-test

This helps gather more accurate API usage data that informs efforts on how to safely migrate containerd clients to 2.0.

Signed-off-by: Chris Henzie <[email protected]>
(cherry picked from commit 52b79f3)
Signed-off-by: Chris Henzie <[email protected]>
@chrishenzie chrishenzie force-pushed the v1alpha2-cri-api-warnings-1.6 branch from bdc45c9 to d727961 Compare August 13, 2024 16:41
@chrishenzie
Copy link
Copy Markdown
Member Author

Can you use git cherry-pick -xs to preserve the original commit hash?

Done, thanks!

@samuelkarp samuelkarp changed the title [release/1.6] Update CRIAPIV1Alpha2 warning lastOccurrence every call [release/1.6] Ensure the CRIAPIV1Alpha2 warning's lastOccurrence is accurate Aug 13, 2024
@samuelkarp samuelkarp merged commit d6dd3d7 into containerd:release/1.6 Aug 13, 2024
@samuelkarp samuelkarp removed the area/cri Container Runtime Interface (CRI) label Sep 6, 2024
@chrishenzie chrishenzie deleted the v1alpha2-cri-api-warnings-1.6 branch July 7, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants