Skip to content

[release/1.6] Make StopContainer RPC idempotent#10530

Merged
kzys merged 1 commit intocontainerd:release/1.6from
k8s-infra-cherrypick-robot:cherry-pick-10521-to-release/1.6
Jul 31, 2024
Merged

[release/1.6] Make StopContainer RPC idempotent#10530
kzys merged 1 commit intocontainerd:release/1.6from
k8s-infra-cherrypick-robot:cherry-pick-10521-to-release/1.6

Conversation

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Jul 31, 2024

This is an automated cherry-pick of #10521

/assign samuelkarp

@saschagrunert
Make StopContainer RPC idempotent
7134b03 
Similar to container removal, the stop of a container should be a noop if
the container has not been found.

Found during: kubernetes-sigs/cri-tools#1536

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 31, 2024
Merged
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 31, 2024

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added the area/cri Container Runtime Interface (CRI) label Jul 31, 2024
@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Jul 31, 2024

/ok-to-test

@saschagrunert
Copy link
Copy Markdown
Contributor

saschagrunert commented Jul 31, 2024

Should we re-trigger the GitHub actions or are the failures legit?

@akhilerm
Copy link
Copy Markdown
Member

akhilerm commented Jul 31, 2024

/retest

Seems its unrelated to the change. Will retrigger the tests.

akhilerm
akhilerm approved these changes Jul 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert It was a flaky test on arm64.

@kzys kzys merged commit 74f2f1b into containerd:release/1.6 Jul 31, 2024
@kiashok kiashok mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

@akhilerm akhilerm akhilerm approved these changes

+1 more reviewer

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samuelkarp samuelkarp

Labels

area/cri Container Runtime Interface (CRI) impact/changelog ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@k8s-infra-cherrypick-robot @k8s-ci-robot @samuelkarp @saschagrunert @akhilerm @kzys @estesp