Make StopContainer RPC idempotent#10521
Conversation
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]>
|
Hi @saschagrunert. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
samuelkarp
added
cherry-pick/1.6.x
cherry-pick/1.7.x
|
/cherrypick release/1.6 |
|
/cherrypick release/1.7 |
|
@saschagrunert: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@saschagrunert: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release/1.7 (I'm fairly sure this automated cherry-pick will fail as there have been significant differences in the CRI files; 1.7 has 2 separate CRI implementations and 1.6 has only the legacy one which is not present in 2.0. Manual backports are likely going to be required here.) |
|
@samuelkarp: new pull request created: #10529 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release/1.6 |
|
@samuelkarp: new pull request created: #10530 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
samuelkarp
added
cherry-picked/1.6.x
samuelkarp
added
the
cherry-picked/1.7.x
6 participants
Similar to container removal, the stop of a container should be a noop if the container has not been found.
Found during: kubernetes-sigs/cri-tools#1536