pkg/userns: deprecate and migrate to github.com/moby/sys/user/userns#10473
Merged
AkihiroSuda merged 3 commits intocontainerd:mainfrom Jul 26, 2024
Merged
pkg/userns: deprecate and migrate to github.com/moby/sys/user/userns#10473AkihiroSuda merged 3 commits intocontainerd:mainfrom
AkihiroSuda merged 3 commits intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
This was referenced Jul 16, 2024
thaJeztah
force-pushed
the
migrate_userns
branch
from
7beaef8 to
7c15a63
Compare
thaJeztah
force-pushed
the
migrate_userns
branch
from
7c15a63 to
d357879
Compare
dosubot
bot
added
dependencies
AkihiroSuda
reviewed
Jul 25, 2024
pkg/userns/userns_deprecated.go
Outdated
Member
There was a problem hiding this comment.
For v2, this package can be just deleted (in a separate commit, for ease of cherry-picking)
thaJeztah
changed the title
full diff: moby/sys@user/v0.1.0...user/v0.2.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
The userns package in libcontainer was integrated into the moby/sys/user module at commit [3778ae603c706494fd1e2c2faf83b406e38d687d][1]. This patch deprecates the containerd fork of that package, and adds it as an alias for the moby/sys/user/userns package. [1]: opencontainers/runc@3778ae6 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
migrate_userns
branch
from
d357879 to
eddd90d
Compare
Member
Author
|
Added a commit that removes the package |
AkihiroSuda
approved these changes
Jul 26, 2024
AkihiroSuda
added
cherry-pick/1.7.x
Member
Author
|
|
Member
Author
|
thaJeztah
added
cherry-picked/1.7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internalopencontainers/runc#3028vendor: github.com/moby/sys/user v0.2.0
full diff: moby/sys@user/v0.1.0...user/v0.2.0
pkg/userns: deprecate and migrate to github.com/moby/sys/userns
The userns package in libcontainer was integrated into the moby/sys/user
module at commit 3778ae603c706494fd1e2c2faf83b406e38d687d.
This patch deprecates the containerd fork of that package, and adds it as
an alias for the moby/sys/user/userns package.