pkg/reference: deprecate SplitObject, and remove for v2.0#10394
Merged
AkihiroSuda merged 2 commits intocontainerd:mainfrom Jun 29, 2024
Merged
pkg/reference: deprecate SplitObject, and remove for v2.0#10394AkihiroSuda merged 2 commits intocontainerd:mainfrom
AkihiroSuda merged 2 commits intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Member
Author
|
I'm considering backporting this (and possibly the other PR) to the 1.7 release branch, so that we can remove it for containerd 2.0. |
Member
Author
|
Opened a PR in BuildKit to remove the use of this function; moby/buildkit#5095 |
The behavior of this function is quite counter-intuitive, as it preserves the delimiter in the result, and its use for external consumers would be very limited. Spec.Digest no longer uses this function, and it appears that BuildKit is currently the only (publicly visible) external consumer of it. This patch deprecates the function. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
deprecate_reference_SplitObject
branch
from
6b7082f to
fec33aa
Compare
cpuguy83
approved these changes
Jun 27, 2024
thaJeztah
changed the title
Member
Author
|
Pushed a commit to remove it as well (for v2.0), after discussing with @dmcgowan The 1.7 backport is only the deprecation; this PR for main also removes it. |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
deprecate_reference_SplitObject
branch
from
8cf6433 to
a723c0c
Compare
dmcgowan
approved these changes
Jun 28, 2024
AkihiroSuda
approved these changes
Jun 29, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
chrishenzie
added
the
cherry-picked/1.7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/reference: deprecate SplitObject
The behavior of this function is quite counter-intuitive, as it preserves
the delimiter in the result, and its use for external consumers would be
very limited.
Spec.Digest no longer uses this function, and it appears that BuildKit is
currently the only (publicly visible) external consumer of it.
This patch deprecates the function.