cri: fix container event can't be handled by containerd when restart containerd#10389
cri: fix container event can't be handled by containerd when restart containerd#10389ningmingxiao wants to merge 1 commit intocontainerd:mainfrom
Conversation
|
Hi @ningmingxiao. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b15f04a to
ebf9227
Compare
d766e3e to
9db6416
Compare
|
how it happened? startContainerExitMonitor B: if A (c.containerStore.Get) is running before B, if container event is coming,events will be droped containerd/pkg/cri/server/events.go Line 190 in ae71819 will return IsNotFound ,will skip handleContainerExit will cause cri container status error. |
containerd Signed-off-by: ningmingxiao <[email protected]>
9db6416 to
63d36d2
Compare
|
#11579 will fix close it. |
fix:#10390
@dmcgowan @fuweid @AkihiroSuda
can you review my new pr ?