[release/1.7] Update api version to v1.7.19#10387
[release/1.7] Update api version to v1.7.19#10387estesp merged 1 commit intocontainerd:release/1.7from
Conversation
|
You need to Because I guess we could consider to copy the LICENSE to the |
|
|
||
| replace github.com/containerd/containerd/api => ./api |
There was a problem hiding this comment.
Note that this means that the code in the api directory will no longer be tested. Currently that's fine, because the code in that directory is what's tagged as api/v1.7.19, but if changes are made after this, they will be untested (and the code is all dead-code).
If we don't plan to do maintenance on api v1.7.x, then we should consider deleting the directory.
There was a problem hiding this comment.
This line is added by make protos and removed by clean-vendor. Also the api module has no tests anyway, any changes to the API in 1.7 are likely to be accompanied by a change in the main module which relies on them for building/testing. Its premature to remove the directory, we can discuss alternative options if and when it becomes a maintenance burden.
There was a problem hiding this comment.
Also the api module has no tests anyway,
Yeah, I was thinking "to test the API used in the containerd codebase", so I wondered if the replace rule should either be always there, or if we should have a test in CI that tests both against the actual current release of the API module, as well as the version in the branch (which would be considered API v1.7.<next> if changes were made)
Signed-off-by: Derek McGowan <[email protected]>
4 participants
Update with latest tagged version to prepare for v1.7.19 release in the main module