[release/1.7] remove imports of errdefs package, and add depguard linter #10367
Merged
dmcgowan merged 2 commits intocontainerd:release/1.7from Jun 20, 2024
Merged
[release/1.7] remove imports of errdefs package, and add depguard linter #10367dmcgowan merged 2 commits intocontainerd:release/1.7from
dmcgowan merged 2 commits intocontainerd:release/1.7from
Conversation
Use of the errdefs package was removed in 308341a but found their way back in through 3be919f This patch removes the imports. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Prevent accidental imports of the packages that moved to a separate module, but that are now an alias. Signed-off-by: Sebastiaan van Stijn <[email protected]>
samuelkarp
approved these changes
Jun 19, 2024
dmcgowan
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/containerd/errdefs#10266remove imports of errdefs package
Use of the errdefs package was removed in 308341a but found their way back in through 3be919f
This patch removes the imports.
golangci-lint: enable depguard for packages that moved
Prevent accidental imports of the packages that moved to a separate
module, but that are now an alias.