Fix TestNewBinaryIOCleanup failing with gotip#10346
Conversation
|
Hi @mauri870. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mauri870
force-pushed
the
hotfix/gotip-test
branch
from
d3a40f9 to
e570c04
Compare
|
@mauri870 Can you sign your commits, so that the tests can proceed. |
This PR ignores a new pidfd file descriptor that is introduced in gotip (future 1.23) and should not be considered when detecting fd leaks. Fixes containerd#10345 Signed-off-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870
force-pushed
the
hotfix/gotip-test
branch
from
921a8cc to
f0aecaa
Compare
Thanks for the reminder, I just signed the commit. |
|
/ok-to-test |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
/cherrypick release/1.7 |
|
@zhsj: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
akhilerm
added
cherry-picked/1.6.x
8 participants
This PR ignores a new pidfd file descriptor that is introduced in gotip (future 1.23) and should not be considered when detecting fd leaks.
Fixes #10345