[release/1.7] Fail integration test early when a plugin load fails#10311
Merged
fuweid merged 2 commits intocontainerd:release/1.7from Jun 13, 2024
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
dmcgowan
changed the title
Avoid running tests when a plugin fails to load and return the init error from the plugin. This prevents the test failing later with an unhelpful error and attempting to find the actual error in the daemon logs. Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit b1a23c4) Signed-off-by: Derek McGowan <[email protected]>
This is not really an error in most cases as most people do not use devmapper, however this shows up as an error in the logs and in the plugin service when querying the plugins. Signed-off-by: Brian Goff <[email protected]> (cherry picked from commit c56f54a) Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
1.7-backport-fail-integration-plugins
branch
from
9bdaebf to
884094b
Compare
Member
Author
|
/retest |
fuweid
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks plugin load success and fixes devmapper always failing when not configured