plugin: Fix runtime interface documentation#1029
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jun 19, 2017
Merged
plugin: Fix runtime interface documentation#1029crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
estesp
reviewed
Jun 19, 2017
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
It looks like that whole section conflates container and task; probably due to the separation of those concepts after the initial implementation?
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 5 5
Lines 781 781
=======================================
Hits 463 463
Misses 204 204
Partials 114 114Continue to review full report at Codecov.
|
Signed-off-by: Samuel Ortiz <[email protected]>
Author
|
@estesp Sorry I missed that, fixed now. |
Member
|
LGTM |
ianlewis
pushed a commit
to ianlewis/containerd
that referenced
this pull request
Dec 8, 2020
…-api Add a generic runtime options api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel Ortiz [email protected]