[release/1.7] Update unpacker to fetch all provided content#10233
Merged
kzys merged 2 commits intocontainerd:release/1.7from May 15, 2024
Merged
[release/1.7] Update unpacker to fetch all provided content#10233kzys merged 2 commits intocontainerd:release/1.7from
kzys merged 2 commits intocontainerd:release/1.7from
Conversation
When a set of layers are provided to the unpacker, then the unpacker should still fetch them regardless of whether they will be used for unpack. The image handler filters are responsible for removing content which is not intended to be fetched. Currently there is no way to use an unpacker and also fetch all platforms. Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit 681a083) Signed-off-by: Derek McGowan <[email protected]>
Allows supporting fetching of all platforms while unpacking for a subset of platforms. Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit 2788604) Signed-off-by: Derek McGowan <[email protected]>
estesp
approved these changes
May 15, 2024
kzys
approved these changes
May 15, 2024
dmcgowan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a set of layers are provided to the unpacker, then the unpacker should still fetch them regardless of whether they will be used for unpack. The image handler filters are responsible for removing content which is not intended to be fetched. Currently there is no way to use an unpacker and also fetch all platforms.
This fixes an issues where the transfer service pull could error out if specifying all platforms but only providing an unpack configuration for a subset.
Backports #10202