Skip to content

[release/1.7] vendor: github.com/containerd/[email protected]#10215

Merged
dmcgowan merged 1 commit intocontainerd:release/1.7from
austinvazquez:vendor-containerd-imgcrypt-1.1.8-to-release-1.7
May 13, 2024
Merged

[release/1.7] vendor: github.com/containerd/[email protected]#10215
dmcgowan merged 1 commit intocontainerd:release/1.7from
austinvazquez:vendor-containerd-imgcrypt-1.1.8-to-release-1.7

Conversation

@austinvazquez
Copy link
Copy Markdown
Member

@austinvazquez austinvazquez commented May 13, 2024

Issue

release/1.7 is showing warnings from indirect dependency gopkg.in/square/go-jose/v2 with no recommendation to resolve.

Description

This change vendors containerd/[email protected] which updates its dependency on square/go-jose/v2 (deprecated) to go-jose/go-jose/v3 (recommended) to resolve warnings for https://pkg.go.dev/vuln/GO-2024-2631.

With 638b474, containerd/imgcrypt was temporarily removed in main, so there would not be a commit to cherry-pick for this change.

full diff:
containerd/imgcrypt@v1.1.7...v1.1.8

Signed-off-by: Austin Vazquez [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @austinvazquez. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez marked this pull request as ready for review May 13, 2024 14:36
This change vendors containerd/[email protected] which updates its
dependency on square/go-jose/v2 (deprecated) to go-jose/go-jose/v3
(recommended) to resolve warnings for https://pkg.go.dev/vuln/GO-2024-2631.

With 638b474, containerd/imgcrypt was
temporarily removed in main, so there would not be a commit to
cherry-pick for this change.

full diff:
containerd/imgcrypt@v1.1.7...v1.1.8

Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez austinvazquez force-pushed the vendor-containerd-imgcrypt-1.1.8-to-release-1.7 branch from 4407f53 to a5d1368 Compare May 13, 2024 15:13
@austinvazquez
Copy link
Copy Markdown
Member Author

Rebased.

@dmcgowan dmcgowan merged commit 970f206 into containerd:release/1.7 May 13, 2024
@austinvazquez austinvazquez deleted the vendor-containerd-imgcrypt-1.1.8-to-release-1.7 branch May 13, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants