[release/1.7] Use LOOP_CONFIGURE when creating loop devices#10209
Conversation
|
Hi @austinvazquez. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
austinvazquez
force-pushed
the
cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7
branch
from
44c621a to
cbc37f5
Compare
|
It would be nice to have #10204 first which vendors golang.org/x/[email protected] to match the base of the cherry-picked commit but not a hard requirement. |
austinvazquez
force-pushed
the
cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7
branch
from
cbc37f5 to
c8e8844
Compare
LOOP_CONFIGURE is a new ioctl that is a lot faster than the LOOP_SET_FD+LOOP_SET_STATUS64 calls Signed-off-by: Alexandru Matei <[email protected]> (cherry picked from commit a782fd6) Signed-off-by: Austin Vazquez <[email protected]>
Replace internal LOOP_CONFIGURE ioctl implementation with IoctlLoopConfigure from sys Signed-off-by: Alexandru Matei <[email protected]> (cherry picked from commit c2dfae8) Signed-off-by: Austin Vazquez <[email protected]>
The struct is now part of golang.org/x/sys. Follow-up for containerd#9805 Signed-off-by: Alexandru Matei <[email protected]> (cherry picked from commit ccec1e6) Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7
branch
from
c8e8844 to
803aaa6
Compare
|
Rebased. |
austinvazquez
deleted the
cherry-pick-a782fd6da2fa9fa350ef754b68b5e80261cfeddc-to-release-1.7
branch
5 participants
Issue
Optimization for creating loop devices on kernels >= 5.8 would be nice to have in release/1.7.
Description
This change backports #9211 and follow on changes #9805, #9813 to release/1.7.
Signed-off-by: Austin Vazquez [email protected]