Skip to content

[release/1.7] vendor: golang.org/x/[email protected]#10204

Merged
dmcgowan merged 5 commits intocontainerd:release/1.7from
austinvazquez:vendor-x-crypto-v0.17.0-to-release-1.7
May 13, 2024
Merged

[release/1.7] vendor: golang.org/x/[email protected]#10204
dmcgowan merged 5 commits intocontainerd:release/1.7from
austinvazquez:vendor-x-crypto-v0.17.0-to-release-1.7

Conversation

@austinvazquez
Copy link
Copy Markdown
Member

@austinvazquez austinvazquez commented May 10, 2024

Issue

Follow-up to #9707 which vendored golang.org/x/[email protected] on release/1.6 to resolve warnings for https://pkg.go.dev/vuln/GO-2023-2402.

imgcrypt (and transitively golang.org/x/crypto) has been temporarily removed from main (see d69ae81) so there wouldn't be a commit to cherry-pick from main.

Description

This change vendors golang.org/x/[email protected] for the 1.7 release branch to resolve warnings for https://pkg.go.dev/vuln/GO-2023-2402.

Note: golang.org/x/[email protected] is the minimum recommended version but release/1.6 vendors v0.18.0 so it would be good to align here as well.

Signed-of-by: Austin Vazquez [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @austinvazquez. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez force-pushed the vendor-x-crypto-v0.17.0-to-release-1.7 branch 2 times, most recently from 20d26f9 to e06cde2 Compare May 10, 2024 14:42
@austinvazquez austinvazquez changed the title [release/1.7] vendor: golang.org/x/[email protected] [release/1.7] vendor: golang.org/x/[email protected] May 10, 2024
ktock and others added 5 commits May 10, 2024 15:08
partial cherry-pick of 9937909 which
updated golang.org/x/sys from v0.13.0 to v0.15.0

full diff: golang/sys@v0.13.0...v0.15.0

Signed-off-by: Kohei Tokunaga <[email protected]>
(cherry picked from commit 9937909)
Signed-off-by: Austin Vazquez <[email protected]>
parital cherry-pick of 7842161 which
updated golang.org/x/term from v0.13.0 to v0.15.0 and golang.org/x/text
from v0.13.0 to v0.14.0.

full diff: golang/term@v0.13.0...v0.15.0
full diff: golang/text@v0.13.0...v0.14.0

Signed-off-by: Bryant Biggs <[email protected]>
(cherry picked from commit 7842161)
Signed-off-by: Austin Vazquez <[email protected]>
partial cherry-pick of dfb1753

full diff: golang/sys@v0.15.0...v0.16.0

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit dfb1753)
Signed-off-by: Austin Vazquez <[email protected]>
partial cherry-pick of 5e3e12d which
updates golang.org/x/term from v0.15.0 to v0.16.0

full diff: golang/term@v0.15.0...v0.16.0

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 5e3e12d)
Signed-off-by: Austin Vazquez <[email protected]>
imgcrypt and transitively golang.org/x/crypto was removed in
d69ae81 in mainline to resolve a
circular dependency issue, so there would not be an update to
cherry-pick from mainline.

full diff: golang/crypto@v0.14.0...v0.18.0

Resolves warnings for https://pkg.go.dev/vuln/GO-2023-2402

Signed-off-by: Austin Vazquez <[email protected]>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 25233a2 into containerd:release/1.7 May 13, 2024
@austinvazquez austinvazquez deleted the vendor-x-crypto-v0.17.0-to-release-1.7 branch May 13, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants