Skip to content

Preserve Unprivileged locked flags during remount of bind mounts#10200

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
swagatbora90:preserve-unprivileged-flags
May 10, 2024
Merged

Preserve Unprivileged locked flags during remount of bind mounts#10200
AkihiroSuda merged 1 commit intocontainerd:mainfrom
swagatbora90:preserve-unprivileged-flags

Conversation

@swagatbora90
Copy link
Copy Markdown
Contributor

@swagatbora90 swagatbora90 commented May 10, 2024

@k8s-ci-robot
Copy link
Copy Markdown

Hi @swagatbora90. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swagatbora90 swagatbora90 force-pushed the preserve-unprivileged-flags branch from 1c3f52e to 0597317 Compare May 10, 2024 00:31
@AkihiroSuda AkihiroSuda added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels May 10, 2024
@AkihiroSuda
Copy link
Copy Markdown
Member

/ok-to-test

@swagatbora90 swagatbora90 marked this pull request as ready for review May 10, 2024 17:00
@swagatbora90 swagatbora90 changed the title Preserve CL_UNPRIVILEGED locked flags during remount of bind mounts Preserve Unprivileged locked flags during remount of bind mounts May 10, 2024
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@AkihiroSuda AkihiroSuda added this pull request to the merge queue May 10, 2024
Merged via the queue into containerd:main with commit 76895c4 May 10, 2024
@swagatbora90 swagatbora90 deleted the preserve-unprivileged-flags branch May 10, 2024 22:17
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch ok-to-test size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rootless on Bottlerocker failed with failed to mount /run/user/1000/containerd-mount3852074643: operation not permitted

6 participants