Update metadata snapshotter to lease on already exists#10187
Merged
mxpv merged 2 commits intocontainerd:mainfrom May 8, 2024
Merged
Update metadata snapshotter to lease on already exists#10187mxpv merged 2 commits intocontainerd:mainfrom
mxpv merged 2 commits intocontainerd:mainfrom
Conversation
Currently the metadata snapshotter is not consistently adding keys to a lease when already exists is returned. When a lease is provided, any already exists errors should add the relevant key to the lease. It is not expected that clients must explicitly lease a key after calling Prepare/Commit. Signed-off-by: Derek McGowan <[email protected]>
|
Skipping CI for Draft Pull Request. |
dmcgowan
added
cherry-pick/1.6.x
cherry-pick/1.7.x
Signed-off-by: Derek McGowan <[email protected]>
ktock
approved these changes
May 8, 2024
estesp
approved these changes
May 8, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mxpv
approved these changes
May 8, 2024
This was referenced May 9, 2024
thaJeztah
added
cherry-picked/1.6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the metadata snapshotter is not consistently adding keys to a lease when already exists is returned. When a lease is provided, any already exists errors should add the relevant key to the lease. It is not expected that clients must explicitly lease a key after calling Prepare/Commit.