Add IsNotFound case to ListPodSandboxStats#10023
Merged
fuweid merged 1 commit intocontainerd:mainfrom Apr 2, 2024
Merged
Conversation
Fixes containerd#10013. It seems we can end up in a spot where the sandbox store still has a listing for a pod, whereas containerds underlying store has removed it. It might be better to shield the caller (k8s) from these transient errors. Signed-off-by: Danny Canter <[email protected]>
estesp
approved these changes
Apr 1, 2024
estesp
approved these changes
Apr 1, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mxpv
approved these changes
Apr 1, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Member
|
thanks @dcantah |
Member
|
@dcantah backports too please? thanks! |
Member
Author
|
Will do! Was waiting for checkin. |
This was referenced Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully fix #10013. It seems we can end up in a spot where the sandbox store still has a listing for a pod, whereas containerds underlying store has removed it. It might be better to shield the caller (k8s) from these transient errors.