Skip to content

[release/1.7] Add support for HPC port forwarding#10008

Merged
fuweid merged 1 commit intocontainerd:release/1.7from
kiashok:supportHPC-portFwd-1.7
Apr 23, 2024
Merged

[release/1.7] Add support for HPC port forwarding#10008
fuweid merged 1 commit intocontainerd:release/1.7from
kiashok:supportHPC-portFwd-1.7

Conversation

@kiashok
Copy link
Copy Markdown
Contributor

@kiashok kiashok commented Mar 27, 2024

This PR is a partial change from commit b97ef91fb7212f512487fc1e28106050ad2f5766

This change only adds support for port forwarding on Windows host process containers by establishing connection to localhost at the requested port since HPCs share the network namespace of the host.
This PR does not change any existing behavior for process isolated or hyperV containers since we'd like to limit changes on a release branch.

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Mar 27, 2024

@cpuguy83 @MikeZappa87 @fuweid @kevpar could you please take a look when you have some time please? Its a partial backport of the port forwarding changes that were checked into the containerd/main branch yesterday. Thanks!

@kiashok kiashok changed the title Add support for HPC port forwarding [release/1.7] Add support for HPC port forwarding Mar 27, 2024
@kiashok kiashok force-pushed the supportHPC-portFwd-1.7 branch from ba893ef to 4d648f9 Compare March 28, 2024 01:54
@kiashok kiashok force-pushed the supportHPC-portFwd-1.7 branch from 4d648f9 to 4e00d82 Compare March 28, 2024 13:46
@AkihiroSuda
Copy link
Copy Markdown
Member

We do not backport a new feature unless there is an exceptional reason

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Apr 1, 2024

We do not backport a new feature unless there is an exceptional reason

@AkihiroSuda We get constant requests from customers to fix this. Unfortunately, we missed to check in port forwarding support for HPC therefore we need to fix this in 1.7. What is the process to get this approved?

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Apr 8, 2024

We do not backport a new feature unless there is an exceptional reason

@AkihiroSuda We get constant requests from customers to fix this. Unfortunately, we missed to check in port forwarding support for HPC therefore we need to fix this in 1.7. What is the process to get this approved?

@AkihiroSuda is this ok to have?

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Apr 8, 2024

cc @margichen

@AkihiroSuda
Copy link
Copy Markdown
Member

We do not backport a new feature unless there is an exceptional reason

@AkihiroSuda We get constant requests from customers to fix this. Unfortunately, we missed to check in port forwarding support for HPC therefore we need to fix this in 1.7. What is the process to get this approved?

@AkihiroSuda is this ok to have?

If this is a bug fix, yes

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Apr 8, 2024

@fuweid @MikeZappa87 could you please take a look? Thanks!

Comment thread pkg/cri/sbserver/sandbox_portforward_windows.go Outdated
@kiashok kiashok force-pushed the supportHPC-portFwd-1.7 branch from 4e00d82 to e991643 Compare April 11, 2024 17:26
@kiashok kiashok force-pushed the supportHPC-portFwd-1.7 branch from e991643 to f649e51 Compare April 19, 2024 18:29
@kiashok kiashok force-pushed the supportHPC-portFwd-1.7 branch from f649e51 to 3df5d44 Compare April 19, 2024 18:32
@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Apr 19, 2024

@cpuguy83 @MikeZappa87 could you please take a look? :) Thanks!

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit b4ae688 into containerd:release/1.7 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants