-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestContainerPTY occasionally fails on windows due to expected \x00 in output
#8422
Comments
@gabriel-samfira Hi,I don't have a windows environment to reproduce it, do you have time to help look at it. Thanks |
Hi @Iceber Yup. I'll have a look! |
I have not forgotten about this. While reproducing this, it seems that the container exits normally, but there's nothing in the |
@aznashwan would you mind taking this one? I've been sidetracked a bit and this deserves some attention. Thanks! |
While I am unsure of the cause yet, I've run the workflow with only the flaky test on repeat a dozen times or so to see how it behaves. TL;DR:
The runs on my fork, done over this containerd commit, can be broken down as follows:
At this stage I suspect it may be related to either how the tests are set up, or it really is a random I/O failure in HCS, but will be investigating further... |
expected \x00 in output
expected \x00 in output
Description
TestContainerPTY occasionally fails on windows due to
expected \x00 in output
.containerd/integration/client/container_test.go
Lines 2699 to 2702 in fdd1be6
https://github.com/containerd/containerd/actions/runs/4701717798/jobs/8338201800?pr=8393#step:16:49
https://github.com/containerd/containerd/actions/runs/4750205702/jobs/8438224967?pr=8418#step:16:50
Occurrences
The text was updated successfully, but these errors were encountered: