Skip to content

Unnecessary log message saying "cleanup warnings" when there seems to be none #7941

@SergeyKanzhelev

Description

@SergeyKanzhelev

Description

Getting messages like the following on regular cleanup:

MESSAGE: "time="2023-01-09T21:42:28.541434027Z" level=warning msg="cleanup warnings time=\"2023-01-09T21:42:28Z\" level=info msg=\"starting signal loop\" namespace=k8s.io pid=5551850\n""

This logic is not ideal as we are getting this warning on any cluster:

log.G(ctx).Warnf("cleanup warnings %s", s)

"starting signal loop" comes from https://github.com/containerd/containerd/blob/main/runtime/v2/shim/shim_unix.go#L74
likely triggered here: https://github.com/containerd/containerd/blob/main/runtime/v2/shim/shim.go#L319

It seems that this warning is unnecessary and can be removed

Steps to reproduce the issue

  1. Take any k8s cluster with containerd
  2. Restart the pod

Describe the results you received and expected

No unnecessary warning logs

What version of containerd are you using?

1.6 (looking at code, main seems to be affected)

Any other relevant information

No response

Show configuration if it is related to CRI plugin.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions