Skip to content

Follow-ups on PR #5904 - Setup pod network after creating the sandbox container #7441

@qiutongs

Description

@qiutongs

There are non-blocking comments/discussions in #5904. Created this issue to track each of those.

  1. When running integration test locally, I have to add two env variables ENABLE_CRI_SANDBOXES="" CONTAINERD_RUNTIME=runc. This shouldn't be necessary.
  2. container_update_resources.go should be platform agnostic but it isn't. That leads to copied function in pkg/cri/server/container_update_resources_other.go.
  3. https://github.com/containerd/containerd/pull/5904/files#r979156661
  4. https://github.com/containerd/containerd/pull/5904/files#r969022061
  5. https://github.com/containerd/containerd/pull/5904/files#r953876126
  6. https://github.com/containerd/containerd/pull/5904/files#r969034596
  7. https://github.com/containerd/containerd/pull/5904/files#r979151113
  8. Update container with sandbox metadata after NetNS is created #7481 (comment)
  9. [port #5904 to sbserver] Setup pod network after creating the sandbox container #7426 (comment)
  10. https://github.com/containerd/containerd/pull/7426/files#r997607252
  11. Follow-ups on PR #5904 - Setup pod network after creating the sandbox container #7441 (comment)

Metadata

Metadata

Assignees

Labels

area/criContainer Runtime Interface (CRI)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions