Skip to content

can't edit object in content store #6846

@zhanghe9702

Description

@zhanghe9702

Description

i am just generate an oci runtime config, and then ingest it to content store, after that i edit this object by reference, i found that any content i add in editor was lost, and output ctr: commit failed: blob with expected digest sha256:a5d93b6db095ac1ddfcb976df7a6cebac94a3826d21dfefa42ad43b58b159916 exists: already exists
i found that is because ctr can't catch editor process operation, see my commit

Steps to reproduce the issue

  1. sudo bin/ctr oci spec > /home/zhanghe/config.json
  2. cat /home/zhanghe/config.json | sudo bin/ctr content ingest testconfig -expected-size 9425 -expected-digest sha256:a5d93b6db095ac1ddfcb976df7a6cebac94a3826d21dfefa42ad43b58b159916
  3. sudo bin/ctr content edit --editor/usr/bin/vim sha256:a5d93b6db095ac1ddfcb976df7a6cebac94a3826d21dfefa42ad43b58b159916
    append any text in editor, like vim, then :wq
    ctr: commit failed: blob with expected digest sha256:a5d93b6db095ac1ddfcb976df7a6cebac94a3826d21dfefa42ad43b58b159916 exists: already exists

Describe the results you received and expected

we should able to edit content use editor vim/emacs

What version of containerd are you using?

zhanghe@zhanghe:~/go/src/github.com/containerd/containerd$ bin/containerd --version containerd github.com/containerd/containerd v1.6.0-254-gbe60973a3.m be60973.m

Any other relevant information

No response

Show configuration if it is related to CRI plugin.

version = 2
root = "/home/zhanghe/go/src/github.com/containerd/containerd/_output/var/lib/containerd"
state = "/home/zhanghe/go/src/github.com/containerd/containerd/_output/run/containerd"
[grpc]
address = "/home/zhanghe/go/src/github.com/containerd/containerd/_output/run/containerd/containerd.sock"
[debug]
address = "/home/zhanghe/go/src/github.com/containerd/containerd/_output/run/containerd/debug.sock"
disabled_plugins = ["io.containerd.grpc.v1.cri"]
oom_score = 0

imports = ["/etc/containerd/config.toml"]

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions