Skip to content

TestTaskResize not testing anything #6249

@cpuguy83

Description

@cpuguy83

Description

The integration test TestTaskResize is not actually testing anything.

Since the test does not actually even allocate a terminal all it's really doing is ensuring that the shim doesn't return an error when there is no terminal.

Steps to reproduce the issue

N/A

Describe the results you received and expected

We should have a test that handles a couple of different scenarios.
I would actually expect the test to fail in its current form but the runc shim explicitly returns nil when there is no tty instead of something like ErrInvalidArgument.

This is a little tricky to do because we need tests for both Windows and Linux which will be very different in implementation.

What version of containerd are you using?

N/A

Any other relevant information

No response

Show configuration if it is related to CRI plugin.

No response

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions