(Copied from #4990 (comment))

Lines 131 to 145 in f07e181

    
           // setupLoop looks for (and possibly creates) a free loop device, and 
        
           // then attaches backingFile to it. 
        
           // 
        
           // When autoclear is true, caller should take care to close it when 
        
           // done with the loop device. The loop device file handle keeps 
        
           // loFlagsAutoclear in effect and we rely on it to clean up the loop 
        
           // device. If caller closes the file handle after mounting the device, 
        
           // kernel will clear the loop device after it is umounted. Otherwise 
        
           // the loop device is cleared when the file handle is closed. 
        
           // 
        
           // When autoclear is false, caller should be responsible to remove 
        
           // the loop device when done with it. 
        
           // 
        
           // Upon success, the file handle to the loop device is returned. 
        
           func setupLoop(backingFile string, param LoopParams) (string, error) {

This function's autoclear handling looks suspicious. The comment says that the caller should close the file handle, but it returns the file path. So all of the associated file handles would be closed when the function returns.

	// setupLoop looks for (and possibly creates) a free loop device, and
	// then attaches backingFile to it.
	//
	// When autoclear is true, caller should take care to close it when
	// done with the loop device. The loop device file handle keeps
	// loFlagsAutoclear in effect and we rely on it to clean up the loop
	// device. If caller closes the file handle after mounting the device,
	// kernel will clear the loop device after it is umounted. Otherwise
	// the loop device is cleared when the file handle is closed.
	//
	// When autoclear is false, caller should be responsible to remove
	// the loop device when done with it.
	//
	// Upon success, the file handle to the loop device is returned.
	func setupLoop(backingFile string, param LoopParams) (string, error) {

flaky test: TestRwLoop: no space left on device #4969

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions