Skip to content

Why does containerd not use the Update interface of the snapshotter plugin? #3434

@wangpeng168

Description

@wangpeng168

When I use the third-party snapshotter plugin (for example: the snapshotter plugin in firecracker-containerd) needs to call the Update interface to change the label for the snapshot, containerd does not call the Update interface of the snapshotter plugin.

When the proposal needs to update the snapshot label, it hopes to update the data to the metadata.db of the third-party snapshotter plugin.

Key code:
https://github.com/containerd/containerd/blob/master/metadata/snapshot.go
func (s *snapshotter) Update(ctx context.Context, info snapshots.Info, fieldpaths ...string) (snapshots.Info, error)

===========
Add a little more:
Since the Prepare and View interfaces have passed snapshots.Opt to the snapshotter, why doesn't the Update interface pass snapshots.Info and fieldpaths to the snapshotter?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions