Description
When working to embed containerd as demonstrated in the initial post in #1615, the dependency resolution (admittedly, using dep) resolved v1.2.0-rc2 as the latest possible version. After further investigation this is due to the following import statement in services/server/server_solaris.go:
srvconfig "github.com/containerd/containerd/server/config"
which should be:
srvconfig "github.com/containerd/containerd/services/server/config"
The current statement is missing services/.
Steps to reproduce the issue:
- Attempt to vendor a dependency including
containerd/services/server.
Describe the results you received:
Version 1.2.0-rc2 is the latest whose imports can all be resolved.
Describe the results you expected:
Resolution to a newer v1.2.x tag (eg. 1.2.6).
Output of containerd --version:
N/A - introduced in commit 06616da
I'm submitting a PR to fix this and one other small issue I noticed.
Description
When working to embed containerd as demonstrated in the initial post in #1615, the dependency resolution (admittedly, using
dep) resolved v1.2.0-rc2 as the latest possible version. After further investigation this is due to the following import statement inservices/server/server_solaris.go:which should be:
The current statement is missing
services/.Steps to reproduce the issue:
containerd/services/server.Describe the results you received:
Version 1.2.0-rc2 is the latest whose imports can all be resolved.
Describe the results you expected:
Resolution to a newer v1.2.x tag (eg. 1.2.6).
Output of
containerd --version:N/A - introduced in commit 06616da
I'm submitting a PR to fix this and one other small issue I noticed.