Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sockets to unix socket #21

Closed
crosbymichael opened this issue Dec 14, 2015 · 0 comments
Closed

Convert sockets to unix socket #21

crosbymichael opened this issue Dec 14, 2015 · 0 comments
Milestone

Comments

@crosbymichael
Copy link
Member

The final resolve is that containerd only be accessed over unix socket because the api is local to the machine.

@crosbymichael crosbymichael added this to the alpha milestone Dec 14, 2015
dcantah pushed a commit to dcantah/containerd that referenced this issue May 11, 2020
ambarve pushed a commit to ambarve/containerd that referenced this issue Nov 22, 2021
Currently on windows we preserve only 2 containerd panic.log
files at a time, this means that in case of multiple containerd
restarts we may loses old panic.log information. This PR attempts
to preserve that info, by logging it to debug via logrus.

Logging individual goroutines can get too noisy, instead log the
file content in 16KB chunks. There seems to be a limit on the
message size and the maximum power of 2 that worked was 16KB.

This also enables for quicker containerd restart RCAs, since
the time of restart and the dumps become available to the event/log
collectors.

Signed-off-by: Maksim An <[email protected]>
jepio pushed a commit to jepio/containerd that referenced this issue Dec 3, 2021
Ignore unified paths with no subsystem
katiewasnothere pushed a commit to katiewasnothere/containerd that referenced this issue Apr 5, 2022
Currently on windows we preserve only 2 containerd panic.log
files at a time, this means that in case of multiple containerd
restarts we may loses old panic.log information. This PR attempts
to preserve that info, by logging it to debug via logrus.

Logging individual goroutines can get too noisy, instead log the
file content in 16KB chunks. There seems to be a limit on the
message size and the maximum power of 2 that worked was 16KB.

This also enables for quicker containerd restart RCAs, since
the time of restart and the dumps become available to the event/log
collectors.

Signed-off-by: Maksim An <[email protected]>
jseba pushed a commit to jseba/containerd that referenced this issue Aug 25, 2023
Make version report correctly on binaries
jseba pushed a commit to jseba/containerd that referenced this issue Aug 25, 2023
…on Go 1.16

Go 1.16 more aggressively forces use of go modules, and as a result for some
steps will ignore the vendor directory, causing the build to fail:

    make REF=v1.4.2 RUNC_REF=59ad417c14143ae6b34e9cf88cf3f6e9c6d5f9e8 GOVERSION=1.16.0 docker.io/library/ubuntu:bionic

    containerd#21 1.417 make[1]: Entering directory '/root/containerd'
    containerd#21 1.418 + pwd
    containerd#21 1.418 + make -C /go/src/github.com/containerd/containerd --no-print-directory DESTDIR=/root/containerd VERSION=1.4.2 REVISION=b321d358e6eef9c82fa3f3bb8826dca3724c58c6 PACKAGE=containerd.io binaries install
    containerd#21 1.579 + bin/ctr
    containerd#21 1.587 go: cannot find main module, but found vendor.conf in /go/src/github.com/containerd/containerd
    containerd#21 1.587 	to create a module there, run:
    containerd#21 1.587 	go mod init
    containerd#21 1.589 Makefile:193: recipe for target 'bin/ctr' failed
    containerd#21 1.589 make[2]: *** [bin/ctr] Error 1
    containerd#21 1.590 make[1]: *** [binaries] Error 2
    containerd#21 1.590 debian/rules:23: recipe for target 'binaries' failed
    containerd#21 1.590 make[1]: Leaving directory '/root/containerd'
    containerd#21 1.596 debian/rules:18: recipe for target 'build' failed
    containerd#21 1.596 make: *** [build] Error 2
    containerd#21 1.596 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
    ------
    executor failed running [/bin/sh -c /root/build-deb]: exit code: 2
    make[1]: *** [build] Error 1
    make: *** [docker.io/library/ubuntu:bionic] Error 2

    make REF=v1.4.2 RUNC_REF=59ad417c14143ae6b34e9cf88cf3f6e9c6d5f9e8 GOVERSION=1.16.0 docker.io/library/centos:7

    ...
    containerd#23 3.267 + make man
    containerd#23 5.145 + man/ctr.8
    containerd#23 5.146 go run cmd/gen-manpages/main.go ctr.8 man
    containerd#23 5.366 cmd/gen-manpages/main.go:27:2: no required module provides package github.com/containerd/containerd/cmd/containerd/command: working directory is not part of a module
    containerd#23 5.366 cmd/gen-manpages/main.go:28:2: no required module provides package github.com/containerd/containerd/cmd/ctr/app: working directory is not part of a module
    containerd#23 5.366 cmd/gen-manpages/main.go:29:2: no required module provides package github.com/urfave/cli: working directory is not part of a module
    containerd#23 5.368 make: *** [man/ctr.8] Error 1
    containerd#23 5.369
    containerd#23 5.369
    containerd#23 5.369 RPM build errors:
    containerd#23 5.369 error: Bad exit status from /var/tmp/rpm-tmp.XNaFt7 (%build)
    containerd#23 5.369     Bad exit status from /var/tmp/rpm-tmp.XNaFt7 (%build)
    ------
    executor failed running [/bin/sh -c /root/build-rpm]: exit code: 1
    make[1]: *** [build] Error 1
    make: *** [docker.io/library/centos:7] Error 2

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant